[Intel-gfx] [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there

Jesse Barnes jbarnes at virtuousgeek.org
Fri Oct 7 16:08:37 CEST 2011


On Thu,  6 Oct 2011 20:30:35 -0300
Eugeni Dodonov <eugeni at dodonov.net> wrote:

> From: Eugeni Dodonov <eugeni.dodonov at intel.com>
> 
> This allows to avoid talking to a non-existent bus repeatedly until we
> finally timeout. The non-existent bus is signalled by -ENXIO error,
> provided by i2c_algo_bit:bit_doAddress call.
> 
> As the advantage of such change, all the other routines which use
> drm_get_edid would benefit for this timeout.
> 
> As the disadvantage comes the fact that I only tested it on Intel
> cards, so I am not sure whether it would work on nouveau and radeon.
> 
> This change should potentially fix
> https://bugs.freedesktop.org/show_bug.cgi?id=41059

I think I like this, assuming i2c doesn't lie to us.  But won't we spam
the log quite a bit?  We do detection a lot because userspace often
polls it and performs detection at app startup a lot.

Jesse



More information about the Intel-gfx mailing list