[Intel-gfx] [PATCH 1/3] drm/i915: collect more per ring error info

[Chris Wilson]

On Fri, 7 Oct 2011 15:52:01 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Oct 04, 2011 at 02:11:51PM -0700, Ben Widawsky wrote:
> > V1: Just added per ring page faults
> > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > 
> > V2: Added much more per ring stuff
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> 
> While you wrestle this, can we cut down on the line-noise a bit by using
> ring->mmio_base an per-ring functions? By storing VCS, BCS, RCS in
> ring->id instead of the flags that are currently there this should reduce
> quite a bit.

You beat me to it, I was also going to suggest this. Seconded ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre