[Intel-gfx] [PATCH 2/6] drm/i915: kicking rings stuck on semaphores considered harmful

[Chris Wilson]

On Tue, 11 Oct 2011 16:39:10 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> If our semaphore logic gets confused and we have a ring stuck waiting
> for one, there's a decent chance it'll just execute garbage when being
> kicked. Also, kicking the ring obscures the place where the error
> first occured, making error_state decoding much harder.
> 
> So drop this an let gpu reset handle this mess in a clean fashion.
> 
> In contrast, kicking rings stuck on MI_WAIT is rather harmless, at
> worst there'll be a bit of screen-flickering. There's also old
> broken userspace out there which needs this as a  work-around.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Reviewed-by: Chris Wilson <chris at hchris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre