[Intel-gfx] [PATCH 3/3] drm/i915: Force sync command ordering

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 11 21:16:55 CEST 2011


On Tue, 11 Oct 2011 11:31:56 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> This will strongly order synchronization commands with respect to 3d
> state and 3d primitive commands. AFAIK, this shouldn't impact anything
> as these sync commands are all for privileged (or ppgtt) batches only,
> so user space should not be relying on this, and the kernel wouldn't be
> relying on 3d state or primitive commands.
> 
> This will help when we enable PPGTT, and perhaps this synchronization is
> currently useful and I just don't realize it.
> 
> This was found through doc inspection by Ken and applies to Gen6+;
> 
> Reported-by: Kenneth Graunke <kenneth at whitecape.org>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

Ok, that bit does look quite important..., and the code also looks
correct!
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list