[Intel-gfx] [PATCH 3/4] drm/i915: extract constant offset setting

Ben Widawsky ben at bwidawsk.net
Thu Oct 13 19:14:10 CEST 2011

On Thu, Oct 13, 2011 at 10:46:29AM +0200, Daniel Vetter wrote:
> On Wed, Oct 12, 2011 at 03:56:21PM -0700, Ben Widawsky wrote:
> > Simple refactor.
> > 
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Imo you can fold this in with the fix. Usually it's good to separate fixes
> from refactoring, but it this special case of just moving around code
> blocks, it doesn't add anything.

I agree, and I had it like this locally, but Chris suggested that he
preferred the separation as it highlighted the fix.

I largely do not care, I just want an r-b. So you two can fight it out.


More information about the Intel-gfx mailing list