[Intel-gfx] [PATCH] drm/i915: Fix recursive calls to unmap

[Keith Packard]

On Sat, 29 Oct 2011 19:07:23 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:

> +		/**
> +		 * Flag if GTT ptes shouldn't be modified.
> +		 *
> +		 * This is set when graphics virtual address space
> +		 * should not be changed. It's currently only useful for
> +		 * a workaround which requires that we serialize unmaps.
> +		 */
> +		bool freeze_ptes;
> +

Yucky. yucky. yucky.

What I expected was to see an extra argument passed down through the
call chain instead of a global variable here.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111029/28d3d500/attachment.sig>