[Intel-gfx] [PATCH v2] drm/i915: Fix recursive calls to unmap

[Keith Packard]

On Sun, 30 Oct 2011 18:52:10 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:

> Well, I had to pick one, and looking at the call chain, it seemed there wasn't
> much to gain by doing retiring at this point.

The point is that you're mixing the stuff the commit message talks about
with other changes *which are not mentioned in the commit message* and
which are *unrelated to the bug in question*.

Two changes get two patches, it's pretty simple. And, commit messages
must tell the whole truth and nothing but the truth. I really hate
having to be this careful in reviewing your patches.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111030/d284e666/attachment.sig>