[Intel-gfx] [PATCH] drm/i915: properly cancel rps_work on module unload

Ben Widawsky ben at bwidawsk.net
Mon Sep 5 19:27:18 CEST 2011


On Mon,  5 Sep 2011 10:15:28 +0200
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> The rps disabling code wasn't properly cancelling outstanding work
> items. Also add a comment that explains why we're not racing with
> the work item that could unmask interrupts - that piece of code
> confused me quite a bit.
> 
> v2: Ben Widawsky pointed out that the first patch would deadlock
> (and a few lesser problems). All corrected.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Reviewed-by: Ben Widawsky <ben at bwidawsk.net>

This looks good. I think we need to do something in i915_save_state()
too though.



More information about the Intel-gfx mailing list