[Intel-gfx] [PATCH 1/2] drm/i915: Dumb down the semaphore logic

[Andrew Lutomirski]

On Wed, Sep 7, 2011 at 6:19 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
>
>
> On Sep 7, 2011, at 5:30 PM, Andrew Lutomirski <luto at mit.edu> wrote:
>
>> On Wed, Sep 7, 2011 at 4:12 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
>>> While I think the previous code is correct, it was hard to follow and
>>> hard to debug. Since we already have a ring abstraction, might as well
>>> use it to handle the semaphore updates and compares.
>>>
>>> I don't expect this code to make semaphores better or worse, but you
>>> never know...
>>>
>>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>>> Cc: Eric Anholt <eric at anholt.net>
>>> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
>>> ---
>>>  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    3 +-
>>>  drivers/gpu/drm/i915/i915_reg.h            |    7 +
>>>  drivers/gpu/drm/i915/intel_ringbuffer.c    |  176 +++++++++++++++++++++-------
>>>  drivers/gpu/drm/i915/intel_ringbuffer.h    |    7 +-
>>>  4 files changed, 145 insertions(+), 48 deletions(-)
>>>
>>
>> Sadly, it still instantly crashes.
>>
>> --Andy
>
> Remind me again... Does ssh still work?

I haven't tried, but I'd be surprised.  The *reset* button (the
hardware one that's attached to the motherboard) doesn't work.

--Andy