[Intel-gfx] [PATCH] drm/i915: fix swizzling on gen6+

[Chris Wilson]

On Mon, 12 Sep 2011 22:37:14 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, Sep 12, 2011 at 09:13:39PM +0100, Chris Wilson wrote:
> > On Mon, 12 Sep 2011 20:49:16 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > > Fixes tests/gem_tiled_pread on my snb. I know, mesa doesn't use this
> > > on gen6+, but I also hate failing testcases.
> > 
> > Hmm, I thought gen6 also has DRAM configuration registers that we were
> > meant to set and to follow. Not that I could actually find the
> > cross-references! I've been surprised that it works and scared
> > to poke too hard just in case it was broken underneath. ;-)
> 
> Well, I've checked with my ilk and snb, and now it works for both. ymmv.
> The other options is to return SWIZZLE_UNKOWN back to userspace and
> disable the tests on gen5+. I don't care too much either way, but I think
> making it work is less risky. And now that qa actually runs our tests, we
> might even catch this earlier.

I suspect we are missing some code to handle atypical configurations.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre