[Intel-gfx] [PATCHv3] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI

[Chris Wilson]

On Tue, 20 Sep 2011 13:52:59 +0100, Simon Farnsworth <simon.farnsworth at onelan.co.uk> wrote:
> +	connector = intel_sdvo_find_connector(intel_sdvo);
> +	if (connector->polled == DRM_CONNECTOR_POLL_HPD) {
> +		intel_encoder->hot_plug = intel_sdvo_enable_hotplug;
> +		intel_sdvo_enable_hotplug(intel_encoder);
> +	}

I should have spotted this the first time... This does not look right.
A multi-function SDVO card has multiple connectors. As we enable
hotplug for any functions with support on a global basis, we only need
the single hook. However, the first connector found might not be the one
marked as POLL_HPD. I think the answer is to move this this
initialisation into intel_sdvo_output_setup() where the individual
functions can report whether or not they want hotplug enabling.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre