[Intel-gfx] [PATCH 1/5] drm/i915: remove PP_ON/OFF waits from LVDS code

[Chris Wilson]

On Thu, 22 Sep 2011 11:15:57 +0530, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> These aren't actually needed for correct functionality and can speed up
> boot and resume a bit.

We've been paranoid for years here. Even after I removed them they've
returned.
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_lvds.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 8b521a2..8ef9a45 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -104,8 +104,6 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
>  
>  	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
>  	POSTING_READ(lvds_reg);
> -	if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
> -		DRM_ERROR("timed out waiting for panel to power on\n");
>  
>  	intel_panel_enable_backlight(dev);
>  }
> @@ -129,8 +127,6 @@ static void intel_lvds_disable(struct intel_lvds *intel_lvds)
>  	intel_panel_disable_backlight(dev);
>  
>  	I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
> -	if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
> -		DRM_ERROR("timed out waiting for panel to power off\n");
>  
>  	if (intel_lvds->pfit_control) {
>  		I915_WRITE(PFIT_CONTROL, 0);
> -- 
> 1.7.4.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Chris Wilson, Intel Open Source Technology Centre