[Intel-gfx] [PATCH] intel/decode: decode MI_WAIT_FOR_EVENT

[Eugeni Dodonov]

On Mon, Apr 2, 2012 at 08:08, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> ... and add support to decode MI instructions with functions.
>
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>
---
>  intel/intel_decode.c |   77
> ++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 75 insertions(+), 2 deletions(-)
>
> diff --git a/intel/intel_decode.c b/intel/intel_decode.c
> index df9b704..4141f9e 100644
> --- a/intel/intel_decode.c
> +++ b/intel/intel_decode.c
> @@ -139,6 +139,74 @@ instr_out(struct drm_intel_decode *ctx, unsigned int
> index,
>  }
>
>  static int
> +decode_MI_WAIT_FOR_EVENT(struct drm_intel_decode *ctx)
> +{
> +       if (ctx->gen <= 5) {
> +               instr_out(ctx, 0,
> "MI_WAIT_FOR_EVENT%s%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
> +                         data & (1<<18)? ", pipe B start vblank wait": "",
> +                         data & (1<<17)? ", pipe A start vblank wait": "",
> +                         data & (1<<16)? ", overlay flip pending wait":
> "",
> +                         data & (1<<14)? ", pipe B hblank wait": "",
> +                         data & (1<<13)? ", pipe A hblank wait": "",
> +                         cc_wait,
> +                         data & (1<<8)? ", plane C pending flip wait": "",
> +                         data & (1<<7)? ", pipe B vblank wait": "",
> +                         data & (1<<6)? ", plane B pending flip wait": "",
> +                         data & (1<<5)? ", pipe B scan line wait": "",
> +                         data & (1<<4)? ", fbc idle wait": "",
> +                         data & (1<<3)? ", pipe A vblank wait": "",
> +                         data & (1<<2)? ", plane A pending flip wait": "",
> +                         data & (1<<1)? ", plane A scan linscan line":
> "");
>

Shouldn't it be "plane A scan line wait"?


> +       } else {
> +               instr_out(ctx, 0,
> "MI_WAIT_FOR_EVENT%s%s%s%s%s%s%s%s%s%s%s%s\n",
> +                         data & (1<<20)? ", prite C pending flip wait":
> "", /* ivb */
>

s/prite/sprite/.

The only major question I have about this is if we should add the other
IVB-specific fields as well, besides the (1<<20) one.

Other than that,
Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>

-- 
Eugeni Dodonov
 <http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120402/fbcd026d/attachment.html>