[Intel-gfx] i915_gem_init_aliasing_ppgtt() loop after 55a254ac63a3ac1867d1501030e7fba69c7d4aeb

Daniel Vetter daniel at ffwll.ch
Thu Apr 5 13:55:12 CEST 2012

On Thu, Apr 5, 2012 at 13:04, Konstantin Belousov <kostikbel at gmail.com> wrote:
> it seems that the loop in i915_gem_init_aliasing_ppgtt() over pd_entries
> that calculates pt_addr does nothing after the commit 55a254ac in the
> !dmar case. Would it be better to move needs_dmar check over the whole
> loop ?

For the !dmar case we still need need to compute the physical address
with page_to_phys, so I think the loop is needed.
Daniel Vetter
daniel.vetter at ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list