[Intel-gfx] [PATCH 2/3] drm/i915: check PPS regs for sanity when using eDP

Daniel Vetter daniel at ffwll.ch
Wed Apr 11 18:04:18 CEST 2012


On Tue, Apr 10, 2012 at 10:26:56PM +0100, Chris Wilson wrote:
> On Tue, 10 Apr 2012 11:58:04 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > If these regs don't have valid values, the panel won't come up, and may
> > even cause a system hang.  So do a basic sanity check when an eDP panel
> > is detected.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> Other than adding a cleanup: error path (definitely before the third
> person cut'n'pastes the intel_dp*destroy()), and that checking for zero
> seems a little crude,
> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list