[Intel-gfx] [PATCH 00/14] intel_ringbuffer.c reorg + cleanups

Chris Wilson chris at chris-wilson.co.uk
Wed Apr 11 22:49:54 CEST 2012

On Wed, 11 Apr 2012 22:12:45 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Hi all,
> This patch series is inspired by Ben's ring->get|put_irq cleanup for gen6+ and
> my perpetual hatred for intel_ringbuffer.c.
> It's a lot of churn, but the end result is imho worth it - I almost started to
> like what the ringbuffer abstraction looks like now. There are some follow-up
> cleanups possible, but I think that can wait until we've cleanup up our domain
> tracking and ripped out the flushing_list (if that ever happens).
> Commments, flames and review highly welcome.

It's not offensive. Cleaning up the function names and the
initialisation is certainly worth it. Maybe I was just expecting more.

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list