[Intel-gfx] [PATCH 02/14] drm/i915: set ring->size in common ring setup code

[Daniel Vetter]

On Thu, Apr 12, 2012 at 12:23:47PM -0700, Ben Widawsky wrote:
> On Wed, 11 Apr 2012 22:12:47 +0200
> Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> 
> > Eventually we want to scale the ring size depending upon available
> > gtt space. For now just consolidate this instead of replicating it
> > over all ringbuffer templates.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > ---
> 
> Definitely in the bikeshed category:
> Why not just make it a macro and scrap the member in struct
> intel_ring_buffer?

830/845 need a workaround to reduce the effective ringbuffer size by 2
cachelines. And as alluded in the commit-message, we want to make this
slightly more dynamic. All this pipe_control workarounds eat away way too
much ringbuffer space :(
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48