[Intel-gfx] [PATCH 21/29] drm/i915: initialize DDI buffer translations

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 13 23:11:24 CEST 2012


On Fri, 13 Apr 2012 17:08:57 -0300, Eugeni Dodonov <eugeni.dodonov at intel.com> wrote:
> -	if (IS_HASWELL(dev))
> +	if (IS_HASWELL(dev)) {
>  		intel_init_power_wells(dev);
> +		intel_hsw_prepare_ddi_buffers(dev);
Give this a much more generic, more grandiose name and move the
generation specific routines down a level:
  intel_init_ddi() [but make it more verbose and self-documenting!]

When you do that you'll might consider it to actually a part of the
display initialisation and so move it down below intel_init_display().
Remember it is vital for our sanity that we be able to concisely describe
the sequence of steps required to initialise the GPU.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list