[Intel-gfx] [PATCH 2/2] drm/i915: l3 parity sysfs interface

Chris Wilson chris at chris-wilson.co.uk
Sat Apr 14 01:24:03 CEST 2012


On Fri, 13 Apr 2012 16:05:14 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> Dumb binary interfaces which allow root-only updates of our cache
> remapping registers.  See intel-gpu-tools for how this can/should be
> used.

Initial comments: don't bother posting a read just before a read, and do
return errors from the sysfs read/write functions (the return value is
signed for that purpose). A lesser issue is that if you are worried
about necessity of posting-reads, you should also worry about the effect of
the weak ordering of writes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list