[Intel-gfx] [PATCH 25/29] drm/i915: detect digital outputs on Haswell

Eugeni Dodonov eugeni at dodonov.net
Sat Apr 14 02:37:44 CEST 2012


On Fri, Apr 13, 2012 at 18:17, Chris Wilson <chris at chris-wilson.co.uk>wrote:

> We're starting to get to ridiculous levels of indention. Break the PCH
> detection of SDVO/HDMI outputs into its own routine, and perhaps further
> down in architectures?
>

Yes, both intel_display and intel_hdmi get too overcomplex with those
patches :(.

I haven't done the split in those series because I thought that the plan
was to land those VLV/HSW patches before doing the big display refactoring
we discussed some weeks ago. But I could certainly start doing it.

Daniel, what do you think would best from your dinq maintainership point of
view - refactor those bits here and in other big patches of this series
(fdi and hdmi ones) and then resend all the patches; or have them as is and
do the big refactoring for everything after that?

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120413/ac8fe933/attachment.html>


More information about the Intel-gfx mailing list