[Intel-gfx] [PATCH 06/12] drm/i915: Remove the unsightly "optimisation" from flush_fence()
Chris Wilson
chris at chris-wilson.co.uk
Tue Apr 17 16:31:29 CEST 2012
As i915_wait_request() will first check for an already passed seqno,
doing it also in the caller is a waste of space for a cold path.
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index f7cd3461..bac3570 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2280,11 +2280,6 @@ static int i830_write_fence_reg(struct drm_i915_gem_object *obj)
return 0;
}
-static bool ring_passed_seqno(struct intel_ring_buffer *ring, u32 seqno)
-{
- return i915_seqno_passed(ring->get_seqno(ring), seqno);
-}
-
static int
i915_gem_object_flush_fence(struct drm_i915_gem_object *obj)
{
@@ -2302,14 +2297,11 @@ i915_gem_object_flush_fence(struct drm_i915_gem_object *obj)
}
if (obj->last_fenced_seqno) {
- if (!ring_passed_seqno(obj->ring,
- obj->last_fenced_seqno)) {
- ret = i915_wait_request(obj->ring,
- obj->last_fenced_seqno,
- true);
- if (ret)
- return ret;
- }
+ ret = i915_wait_request(obj->ring,
+ obj->last_fenced_seqno,
+ true);
+ if (ret)
+ return ret;
obj->last_fenced_seqno = 0;
}
--
1.7.10
More information about the Intel-gfx
mailing list