[Intel-gfx] [PATCH 1/2] drm/i915: time out of load detect busy-waits

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 20 21:42:10 CEST 2012


On Fri, 20 Apr 2012 21:03:35 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> If we try to do that and the scanlines just wouldn't advance, we
> busy-hang the machine holding the modeset mutex. Not great for
> debugging.
> 
> References: https://bugzilla.kernel.org/show_bug.cgi?id=43020
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

A second is a bit much, 5 vblanks should do, say 100ms, but this is just
paranoid code. Unfortunately if it hits it means the machine is likely
to keep hitting it. Are little, but noticeable periodic stutters
actually better than a freeze?
Otherwise,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list