[Intel-gfx] [PATCH] drm/i915: properly check for MODESET for kms driver ioctls

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 24 11:41:25 CEST 2012

On Tue, 24 Apr 2012 09:55:08 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Also ditch the cargo-culted dev_priv checks - either we have a
> giant hole in our setup code or this is useless. Plainly bogus
> to check for it in either case.
> v2: Chris Wilson noticed that I've missed one bogus dev_priv check.
> v3: The check in the overlay code is redundant (Chris)
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Never mind, intel_sprite.c goes through an idr to find its planes and
not a simple pointer hanging off dev_priv. Speaking of which we never
free the memory allocated for the planes...

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list