[Intel-gfx] [PATCH] drm/i915: create macros to handle masked bits
daniel at ffwll.ch
Tue Apr 24 15:45:15 CEST 2012
On Tue, Apr 24, 2012 at 02:24:33PM +0100, Chris Wilson wrote:
> On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > ... and put them to so good use.
> > Note that there's functional change in vlv clock gating code, we now
> > no longer spuriously read back the current value of the bit. According
> > to Bspec the high bits should always read zeror, so ORing this in
> > should have no effect.
> > Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> The transforms here look fine, just a moment of concern for not
> repeating the MODE twiddling in init_render_ring after reset.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Queued for -next, thanks for the review. If someone has complains, I can
take it out again ;-)
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48
More information about the Intel-gfx