[Intel-gfx] [PATCH] drm/i915: create macros to handle masked bits

Jesse Barnes jbarnes at virtuousgeek.org
Tue Apr 24 18:12:36 CEST 2012

On Tue, 24 Apr 2012 14:04:12 +0200
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> ... and put them to so good use.
> Note that there's functional change in vlv clock gating code, we now
> no longer spuriously read back the current value of the bit. According
> to Bspec the high bits should always read zeror, so ORing this in
> should have no effect.
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---

Looks nice.  Now we just have to be vigilant about people using it. :)

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Jesse Barnes, Intel Open Source Technology Center

More information about the Intel-gfx mailing list