[Intel-gfx] [PATCH 1/6] drm/i915: Unconditionally initialise the interrupt workers

Jesse Barnes jbarnes at virtuousgeek.org
Tue Apr 24 21:12:36 CEST 2012


On Tue, 24 Apr 2012 18:31:26 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> Rather than duplicate similar code across the IRQ installers, perform
> the initialisation of the workers upfront. This will lead to simpler
> teardown and quiescent code as we can assume that the workers have
> been initialised.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---

Looks nice, and also gives me warm fuzzies about the potential races
between setting up the work queues and interrupts arriving since it
would be all too easy to accidentally call these in postinstall on some
new hw platform.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list