[Intel-gfx] [PATCH 1/2] drm/i915: use mode values consistently when converting to sdvo dtd

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 24 21:24:20 CEST 2012

On Tue, 24 Apr 2012 18:27:57 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> The drm_mode->dtd conversion used the crtc timings, whereas the
> dtd->drm_mod did not set these. Use the standard mode information, not
> the crtc timings, in both cases to make these two functions proper
> inverses of each another.
> Note that this also kills the risk that we handle interlaced timings
> inconsistently because the drm core uses half-frames for crtc timings,
> whereas we need full frames. But interlaced support is pretty decently
> broken anyway for sdvo encoders, so no big deal.

So as I understand it, if we had interlacing or dblscan enabled on the
incoming mode we would have been feeding the display timing into the
magic black box of the SDVO encoder rather the mode line.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list