[Intel-gfx] [PATCH 05/12 v2] drm/i915: drop polled waits from i915_wait_request
daniel at ffwll.ch
Fri Apr 27 16:46:16 CEST 2012
On Thu, Apr 26, 2012 at 04:03:02PM -0700, Ben Widawsky wrote:
> The only time irq_get should fail is during unload or suspend. Both of
> these points should try to quiesce the GPU before disabling interrupts
> and so the atomic polling should never occur.
> This was recommended by Chris Wilson as a way of reducing added
> complexity to the polled wait which I introduced in an RFC patch.
> 09:57 < ickle_> it's only there as a fudge for waiting after irqs
> after uninstalled during s&r, we aren't actually meant to hit it
> 09:57 < ickle_> so maybe we should just kill the code there and fix the breakage
> v2: return -ENODEV instead of -EBUSY when irq_get fails
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
Queued for -next, thanks for the patch.
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48
More information about the Intel-gfx