[Intel-gfx] Find bugs in i915 driver

[Paul Menzel]

Dear Anhua,


five additional comments to Greg’s ones.


Am Dienstag, den 31.07.2012, 07:23 -0700 schrieb Greg KH:
> On Tue, Jul 31, 2012 at 09:17:15AM +0000, Xu, Anhua wrote:
> > Thanks Chris. I add this in the the commit description. The updated patch is below: 
> > 
> > commit 71c3ff04834a01c81a5843996b87397273eb538d
> > Author: Xu Anhua <anhua.xu at intel.com>

1. Looking at your address in the From field of this message there is
"Xu, Anhua", so I am not sure which is your first name.

If it is Anhua, please do the following.

    git config --global author.name "Anhua Xu"

> > Date:   Tue Jul 31 17:16:50 2012 +0800
> > 
> >     i915: make the parameters passed-in coherent with functions'
> >     	definition when calling hdmi/adpa/lvds_pipe_enabled()
> >     
> >     This bug is indroduced by commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37

1. There is a typo: in*t*roduced. The spell checker of your email
program should mention that. Or you hook up Git to check that [1][2][3].

> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> 
> No signed-off-by?  No tag for inclusion in the stable tree?
> 
> This patch isn't going very far :(

2. Please do not just mention the hash of the commit but also the
summary. Only a few people have memorized all hashes. ;-)

        commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37
        Author: Keith Packard <keithp at keithp.com>
        Date:   Sat Aug 6 10:35:34 2011 -0700
        
            drm/i915: Fix PCH port pipe select in CPT disable paths

You can use `git commit --amend --author="Anhua Xu" to edit the last
commit.

3. To include the patch you seem to copy the output of `git log` or `git
show`. The recommended way is to use `git format-patch -s -1`. This way
the commit message is indented correctly.

4. Your first message of this thread included a HTML part. Luckily your
reply did not which suggests that your mail program supports writing
just plain text messages. In the future it would be great if you could
write just plain text messages which is the recommended way for mailing
lists [4].


Thanks,

Paul


[1] http://blog.mpdaugherty.com/2010/04/06/how-to-include-git-hooks-in-a-repository-and-still-personalize-your-machine/
[2] http://stackoverflow.com/questions/1691060/vim-set-spell-in-file-git-commit-editmsg
[3] http://petereisentraut.blogspot.de/2011/01/git-commit-mode.html
[4] http://en.opensuse.org/openSUSE:Mailing_list_netiquette
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120801/c6717e8b/attachment.sig>