[Intel-gfx] [PATCH] drm/i915: fixup desired rps frequency computation

Daniel Vetter daniel at ffwll.ch
Wed Aug 8 22:54:29 CEST 2012


On Wed, Aug 08, 2012 at 09:12:21PM +0100, Chris Wilson wrote:
> On Wed,  8 Aug 2012 17:42:52 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > In commit
> > 
> > commit 20b46e59dd102665ce7168baa215e5b1ee66b69b
> > Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Date:   Thu Jul 26 11:16:14 2012 +0200
> > 
> >     drm/i915: Only set the down rps limit when at the loweset frequency
> > 
> > The computation for the new desired frequency was extracted, but since
> > the desired frequency was passed-by value, the adjustments didn't
> > propgate back. Fix this.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Ouch, how embarrassing - for the reviewer. :(
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list