[Intel-gfx] [PATCH 4/4] drm/i915: Cleanup instdone state when idle

[Ben Widawsky]

On 2012-08-14 00:39, Chris Wilson wrote:
> On Mon, 13 Aug 2012 22:41:11 -0700, Ben Widawsky <ben at bwidawsk.net> 
> wrote:
>> The previous state is bogus when we've gone into idle. Actually 
>> there
>> would be a known state of idle (ie. all units are done), but since 
>> it
>> differs for every platform, we can just set 0, and let the hangcheck
>> progress as normal.
>>
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=52429
>> Tested-by: Guang A Yang <guang.a.yang at intel.com>
>> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
>
> I think you have a point, but I don't think this should be just on 
> idle.
> Everytime we kick off the hangcheck, we should not be comparing to 
> stale
> state.
> -Chris

Are you suggesting this is a patch which already exists somewhere?

-- 
Ben Widawsky, Intel Open Source Technology Center