[Intel-gfx] [PATCH] drm/i915: Don't hardcode the number of pipes in the error state dump

[Daniel Vetter]

On Wed, Aug 15, 2012 at 07:42:15PM +0100, Chris Wilson wrote:
> On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau <damien.lespiau at gmail.com> wrote:
> > From: Damien Lespiau <damien.lespiau at intel.com>
> > 
> > New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> > for_each_pipe() macro and make struct intel_display_error_state is big
> > enough.
> > 
> > V2: Also add the number of pipes emitted (Chris Wilson)
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Queued for -next, thanks for the patch.

> I guess next on your list will be adding some of the PCH register
> states, along with a list of active encoders / connectors etc.

I'm not sure that's worth it, at least usually the gt doesn't fall over
when we anger the pch ... Simply grabbing a register dump for interesting
configurations and comparing them worksforme.

-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48