[Intel-gfx] Fwd: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness

[Daniel Vetter]

Hi Michael,

> ---------- Forwarded message ----------
> From: Michael Chapman <anotherchapman at gmail.com>
> Date: Fri, Aug 17, 2012 at 10:30 PM
> Subject: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness
> To: airlied at gmail.com
>
>
> Hello Dave:
>
> A couple of weeks ago, Carsten Emde helped me fix a display issue on
> my Acer Aspire 5732Z that was similar to the problem on the 5734Z.
> (Please see the email fragment below.) I don't know if he submitted a
> patch, but I was wondering if this fix would be in place for Linux
> 3.6. I've attached a patch file that was made against
> git://people.freedesktop.org/~danvet/drm-intel.

Afaikt this is just I quick hack and I intend to rip it out (same for
the original entry from Carsten Emde). I've sent Carsten Emde a quick
debug patch which should fix his issues for real, but unfortunately
never got a test results for it. To test, please try this patch:

https://bugs.freedesktop.org/attachment.cgi?id=65156

I've volunteered Jani from our team to write up a neat patch series to
fix this issue for good (which should hopefully land in 3.7).

Yours, Daniel

>
> Thank you,
>
> Michael
>
>
> ---------- Forwarded message ----------
> From: Carsten Emde <C.Emde at osadl.org>
> Date: Wed, Jul 25, 2012 at 6:04 PM
> Subject: Re: quirk_invert_brightness and Acer Aspire 5732Z
> To: Michael Chapman <anotherchapman at gmail.com>
>
>
> On 07/25/2012 07:09 PM, Michael Chapman wrote:
>>
>> Subsystem: 1025:0212
>
> This is the patch:
>
> Index: linux-git/drivers/gpu/drm/i915/intel_display.c
> ===================================================================
> --- linux-git.orig/drivers/gpu/drm/i915/intel_display.c
> +++ linux-git/drivers/gpu/drm/i915/intel_display.c
> @@ -6877,7 +6877,8 @@ static struct intel_quirk intel_quirks[]
>         /* Sony Vaio Y cannot use SSC on LVDS */
>         { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
>
> -       /* Acer Aspire 5734Z must invert backlight brightness */
> +       /* Acer Aspire 5732Z and 5734Z must invert backlight brightness */
> +       { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
>         { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
>  };
>
> Please let me know, whether a kernel with this patch still requires
> manual setpci hassle or whether the problem is now fixed.
>
>         -Carsten.
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>



-- 
Daniel Vetter
daniel.vetter at ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch