[Intel-gfx] [PATCH 00/58] modeset-rework, the basic conversion

Daniel Vetter daniel at ffwll.ch
Fri Aug 24 00:39:38 CEST 2012


On Thu, Aug 23, 2012 at 01:26:39PM +0100, Lespiau, Damien wrote:
> On Wed, Aug 22, 2012 at 10:21 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> > Please test the for-damien branch in my personal fdo git repo. I'm rather
> > positive that the patch there should fix this (but in the least it should
> > unearth the real culprit).
> 
> The branch works, but so does HEAD^ on that branch.
> 
> After cherry-picking the PLL commit on top of the modeset-rework
> branch, plugging out the VGA cable still turns off the PLL for LVDS,
> but now triggers the newly introduced asserts see:
> http://damien.lespiau.name/files/temp/vga+lvds-unplug-vga-lvds-fail-full-2.dmesg.bz2

Yeah, the pll changes are just something I've noticed that looks strange,
the real fix is tip. And that one is a real change wrt what the crtc
helper does, so I need to think about it some more.

> I can have a look myself as well, but probably not before Tuesday.

Hm, if you have that dmesg from the branch I've pushed, we hit the WARN
for the case where we grab a fresh pch pll, but somehow think it's still
on. I have a feeling there's something fishy going on. But like I've said
before, the pll stuff is simply something I've noticed while reading
through your dmesg.

Thanks for testing, Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list