[Intel-gfx] [PATCH 2/3] intel_reg_dumper: Dump FDI_RX_DEBUG registers

[Lespiau, Damien]

On Fri, Aug 24, 2012 at 12:14 AM, Ben Widawsky <ben at bwidawsk.net> wrote:
>> +#define FDI_RXA_DEBUG          0xf0020
>> +#define FDI_RXB_DEBUG          0xf1020

[snip]

> My only gripe with this patch is in the naming. Can you please use something
> find-able in the BSPEC, like: FDI_RX_DEBUG_B instead of FDI_RXB_DEBUG

I used the same convention as all the others FDI_[R,T]x_[A,B,C]_*
registers, if you look closely: FDX_TXA_CTL, FDX_TXA_MISC, ... I
believe this is because those registers have been introduced with
ironlake and the ILK spec names them like this while later specs adopt
the _A, _B, _C suffixes. I went for consistency.

-- 
Damien