[Intel-gfx] [PATCH] drm/i915: fixup sparse warnings
Chris Wilson
chris at chris-wilson.co.uk
Mon Dec 3 22:13:52 CET 2012
On Thu, 29 Nov 2012 22:18:51 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> - __iomem where there is none (I love how we mix these things up).
> - Use gfp_t instead of an other plain type.
> - Unconfuse one place about enum pipe vs enum transcoder - for the pch
> transcoder we actually use the pipe enum. Fixup the other cases
> where we assign the pipe to the cpu transcoder with explicit casts.
> - Declare the mch_lock properly in a header.
>
> There is still a decent mess in intel_bios.c about __iomem, but heck,
> this is x86 and we're allowed to do that.
>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Makes-sparse-happy: Chris Wilson <chris at chris-wilson.co.uk>
How about deciding whether it is '(cast) object' or '(cast)object' and
be consistent.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list