[Intel-gfx] [PATCH] drm: Make the HPD status updates debug logs more readable

[Damien Lespiau]

On Tue, Dec 4, 2012 at 5:39 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Dec 04, 2012 at 04:00:17PM +0000, Damien Lespiau wrote:
>> From: Damien Lespiau <damien.lespiau at intel.com>
>>
>> Instead of just printing "status updated from 1 to 2", make those enum
>> numbers immediately readable.
>>
>> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
>
> I like, stupid me can never remember the magic values. For the patch
> itself, can you please also patch the connector updates in
> drm_helper_probe_single_connector_modes (which is required to avoid losing
> hpd events when doing a manual probe cycle) and output_poll_execute. For
> completeness maybe also throw in a debug output in
> drm_helper_disable_unused_functions, but that's only relevant for drivers
> that use the modeset helpers (i.e. not for drm/i915).

v2 sent. I think that the current log messages around ->detect in
drm_helper_probe_single_connector_modes() serves as nice guards around
the detection code and went to "fix" a bigger offender, namely logging
all the previously valid modes when detecting a disconnection.

For the last one, leaving the decision of adding yet another log
message to the users of that helper sounds better to me.

-- 
Damien