[Intel-gfx] [PATCH 6/6] drm/i915: Remove stale comment about intel_dp_detect()

Jani Nikula jani.nikula at linux.intel.com
Fri Dec 14 10:46:20 CET 2012


On Thu, 13 Dec 2012, Damien Lespiau <damien.lespiau at gmail.com> wrote:
> From: Damien Lespiau <damien.lespiau at intel.com>
>
> The function doesn't use any of the registers mentioned, nor does it
> return true or false. Hard to do worse. Remove it, the function is
> absolutely descriptive enough to not need any comment.

Reviewed-by: Jani Nikula <jani.nikula at intel.com>

> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 5ed8fb3..185bf4e 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2343,13 +2343,6 @@ intel_dp_get_edid_modes(struct drm_connector *connector, struct i2c_adapter *ada
>  	return intel_ddc_get_modes(connector, adapter);
>  }
>  
> -
> -/**
> - * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect DP connection.
> - *
> - * \return true if DP port is connected.
> - * \return false if DP port is disconnected.
> - */
>  static enum drm_connector_status
>  intel_dp_detect(struct drm_connector *connector, bool force)
>  {
> -- 
> 1.7.11.7
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



More information about the Intel-gfx mailing list