[Intel-gfx] [PATCH] drm/i915: s/intel_modeset_disable/intel_modeset_hw_freeze/

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 17 16:10:26 CET 2012


On Mon, 17 Dec 2012 15:51:57 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Chris Wilson rightfully complained that the name of this function is
> misleading - it suggests that it's a generic means to disable all
> outputs (and also update all the sw side tracking of the modeset
> state). In effect it only disables the hw to quiescent it in the
> freeze callbacks for suspend/hibernate - since thaw will read-out the
> entire hw state again anyway and so scrap the sw tracking, we don't
> need to update the driver state.
> 
> Also add a comment in the code.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

A nice improvement and stops me from wanting to call it -- it would have
been a nasty mistake.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list