[Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

[Chris Wilson]

On Sat, 29 Dec 2012 11:45:09 -0800, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Sat, 29 Dec 2012 11:49:01 +0000
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> 
> > On Fri, 28 Dec 2012 20:27:27 -0800, Ben Widawsky <ben at bwidawsk.net>
> > wrote:
> > > This refactor clearly identifies the GEN specific portion of the
> > > aliased ppgtt code. Aside from some of the gen specific parts being
> > > extracted, it also preps us for an upcoming patch that pulls out
> > > the size, which has some nice benefits.
> > 
> > Error handling looks a little wonky.
> 
> I've not looked in much detail yet, but I'll assume you're right since
> I did this pretty quickly. So given that assumption, what do you think
> of the patches, useful, or waste of code complexity?

The mention of transitioning ppgtt to use objects sounds intriguing, and
without digging into the details, does seem a worthwhile design. This
series looks fine as a mean of cutting the code up into manageable
chunks.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre