[Intel-gfx] [PATCH 2/2] drm/i915: catch gtfifo errors on forcewake_put

Chris Wilson chris at chris-wilson.co.uk
Sat Feb 4 00:10:09 CET 2012


On Fri,  3 Feb 2012 14:31:41 -0800, Ben Widawsky <ben at bwidawsk.net> wrote:
> This is similar to a patch I wrote several months ago. It's been updated
> for the new FORCEWAKE_MT, and it also no longer clears the debug
> register as it may be helpful to get that for the error state.  Also
> recommended by Chris Wilson, use WARN() instead of DRM_ERROR, so we can
> get a backtrace.
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

Can we use the read of GTFIFODBG in place of the POSTING_READ? And do we
really need to watch all the GTFIFODBG reads in the trace, or can I
squelch that noise with a I915_READ_NOTRACE?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list