[Intel-gfx] [PATCH 1/2] drm/i915: Remove use of the autoreported ringbuffer HEAD position

Keith Packard keithp at keithp.com
Wed Feb 8 18:36:29 CET 2012

<#part sign=pgpmime>
On Wed, 8 Feb 2012 15:54:25 +0100, Daniel Vetter <daniel at ffwll.ch> wrote:

> I'm on the fence whether we should include this in -fixes. On one hand it
> fixes a severe issue on snb, but introduces a perf regression without the
> second patch. Otoh we've never shipped snb without it broken like this.
> But if it turns out that this is broken on ilk and earlier, too, I think
> we definitely need these two patches in -fixes.

The first one is a simple bug fix -- not attempting to use the status
page value. That seems reasonable for -fixes.

The second one has a bunch of global changes which seems less suitable
for -fixes, especially as it now requires that the driver reliably track
ring positions, which seems a bit perilous to me.

keith.packard at intel.com

More information about the Intel-gfx mailing list