[Intel-gfx] [PATCH 1/2] drm/i915: Record the in-flight requests at the time of a hang

Daniel Vetter daniel at ffwll.ch
Wed Feb 8 23:33:22 CET 2012

On Wed, Feb 08, 2012 at 08:09:27PM +0000, Chris Wilson wrote:
> Being able to tally the list of outstanding requests with the sequence
> of commands in the ringbuffer is often useful evidence with respect to
> driver corruption.
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

I like this and I think we can nicely put some more robust
request->batchbuffer_bo tracking on top of this instead of the current
broken heuristics. Two bikeshed comments
- consisten seqno pretty-printing in the debugfs file
- some mention that you've gone ahead and refactored the per-ring stuff
  quite a bit might be good. It confused me quite a bit until I've
  noticed what you've done and found the actual change ...

Cheers, Daniel
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48

More information about the Intel-gfx mailing list