[Intel-gfx] [PATCH] drm/i915/lvds: Always use the presence pin for LVDS on PCH

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 9 18:33:23 CET 2012

On Thu, 09 Feb 2012 09:13:35 -0800, Keith Packard <keithp at keithp.com> wrote:
> <#part sign=pgpmime>
> On Thu,  9 Feb 2012 09:35:53 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > With the introduction of the PCH, we gained an LVDS presence pin but we
> > continued to use the existing logic that asserted that LVDS was only
> > supported on certain mobile chipsets. However, there are desktop
> > IronLake systems with LVDS attached which we fail to detect. So for PCH,
> > trust the LVDS presence pin and quirk all the lying manufacturers.
> Uh. I don't see where this is using the LVDS presence pin. Am I just
> missing something?

That code already existed in intel_lvds_init():
  if (HAS_PCH_SPLIT(dev)) {
     if (I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
        return false

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list