[Intel-gfx] [PATCH] drm/i915: Don't lock panel registers when downclocking

[Sean Paul]

On Mon, Feb 13, 2012 at 5:08 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Wed, Feb 01, 2012 at 05:31:30PM -0500, Sean Paul wrote:
>> This patch removes the locking from the downclock routines since we are no
>> longer locking the registers at all. See ed10fca9 for the original commit
>> changing this philosophy.
>>
>> Signed-off-by: Sean Paul <seanpaul at chromium.org>
>
> I've thought this was due to paranoia because we don't trust our own code
> and because we don't trust the bios to randomly lock this again. Without
> any reasons to the contrary, I'll prefer to keep this.

Thanks for the explanation, Daniel, however I'd ask that you
reconsider this patch.

The state coming into the downclock functions is unlocked and without
this patch, the state coming out is locked. This causes at least one
warning in the code from assert_panel_unlocked.

Sean


>
> Yours, Daniel
> --
> Daniel Vetter
> Mail: daniel at ffwll.ch
> Mobile: +41 (0)79 365 57 48