[Intel-gfx] [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable

[Ben Widawsky]

On Tue, 21 Feb 2012 21:11:07 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Tue, 21 Feb 2012 12:59:37 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > @@ -1828,6 +1829,9 @@ drm_intel_gem_bo_mrb_exec2(drm_intel_bo *bo, int used,
> >  	execbuf.rsvd1 = 0;
> >  	execbuf.rsvd2 = 0;
> >  
> > +	if (getenv("INTEL_DEVID_OVERRIDE"))
> > +		goto skip_execution;
> 
> I'm not thrilled about calling getenv() for every execbuffer. And what
> about the original execbuffer path?
> -Chris
> 

I agree. I think the right way to do this is if the environment variable is
set, you can override the function pointer in drm_intel_bufmgr_gem_init or
something like that.

Also, I think it's a bit misleading that the effect of overriding the
devid is to not emit batches. If nothing else because we may actually
want to override the devid and have it do something in the future, and
expecting the override to not emit could be bad.