[Intel-gfx] [PATCH 2/2] drm/i915: remove vblank wait around sprite buffer changes

Jesse Barnes jbarnes at virtuousgeek.org
Mon Feb 27 21:40:11 CET 2012


The docs made me paranoid about updating the surface reg too quickly,
but experiements have shown it to be safe on the two supported
platforms, so remove the waits to avoid blocking apps.

Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_sprite.c |   14 +-------------
 1 files changed, 1 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index a083504..b08c55f 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -489,20 +489,8 @@ intel_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
 	}
 
 	/* Unpin old obj after new one is active to avoid ugliness */
-	if (old_obj) {
-		/*
-		 * It's fairly common to simply update the position of
-		 * an existing object.  In that case, we don't need to
-		 * wait for vblank to avoid ugliness, we only need to
-		 * do the pin & ref bookkeeping.
-		 */
-		if (old_obj != obj) {
-			mutex_unlock(&dev->struct_mutex);
-			intel_wait_for_vblank(dev, to_intel_crtc(crtc)->pipe);
-			mutex_lock(&dev->struct_mutex);
-		}
+	if (old_obj)
 		i915_gem_object_unpin(old_obj);
-	}
 
 out_unlock:
 	mutex_unlock(&dev->struct_mutex);
-- 
1.7.5.4




More information about the Intel-gfx mailing list