[Intel-gfx] [Glamor] [PATCH v3] uxa/glamor: Create glamor pixmap by default.

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 16 11:54:33 CET 2012

On Thu, 12 Jan 2012 15:30:15 +0800, zhigang.gong at linux.intel.com wrote:
> From: Zhigang Gong <zhigang.gong at linux.intel.com>
> Chris,
> According to your previous comments. The X server will not die when
> fail to get a dri buffer for a glamor pixmap, instead it will return
> a BadAlloc. Your previous advice is to pass a BadMatch to the client,
> and I traced into X's dri2 module and found current code can only
> return a BadAlloc. IMHO, this should be ok. Right?

That looks to be the best solution in line with the existing failure
mechanisms along that path.
> Another change is to disable the reuse of bo for glamor textured
> pixmap.
> The last change is reduce the performance gain. ;), I just found
> another 10-20% is come from my latest glamor patchset. 

Hmm, that does suggest that non-native glamor pixmaps were still in use
and that they were not being marked non-reusable i.e. they weren't DRI

The patch looks good to me, so I've pushed it to master, thanks.

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list