[Intel-gfx] [PATCH] drm/i915: Probe SDVO LVDS information

[Adam Jackson]

On Mon, 2012-01-16 at 23:19 +0100, Daniel Vetter wrote:
> On Mon, Nov 28, 2011 at 01:32:11PM -0500, Adam Jackson wrote:
> > No effect besides printing the result in dmesg if debugging is enabled.
> > 
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> 
> This looks strange without dmesg output nor a comment added. Quick survey
> on irc with Jesse and Chris showed that we want interesting stuff decoded
> into dmesg or debugfs ... hint ;-)
> -Daniel

Well:

> > +static void
> > +intel_sdvo_lvds_probe_panel_information(struct intel_sdvo *intel_sdvo)
> > +{
> > +	u8 info;
> > +	intel_sdvo_get_value(intel_sdvo,
> > +			     SDVO_CMD_GET_LVDS_PANEL_INFORMATION,
> > +			     &info, sizeof(info));
> > +}
> > +
> >  static bool
> >  intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
> >  {

intel_sdvo_get_value -> intel_sdvo_write_cmd / intel_sdvo_read_response,
both of which call DRM_{DEBUG,LOG}_KMS.

Which is a little non-obvious without an explicit "yes i'm doing this in
void context, don't panic" comment in the code I guess.  Want a better
version?

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120123/6b12994a/attachment.sig>