[Intel-gfx] [PATCH] drm/i915: [PATCH v4] drm/i915: Fix recursive calls to unmap

Keith Packard keithp at keithp.com
Tue Jan 24 20:30:52 CET 2012

On Mon, 23 Jan 2012 15:11:57 -0800, Ben Widawsky <ben at bwidawsk.net> wrote:

> v3: As Keith Packard pointed out, v2 changed retirement behavior. While
> it was intentional, it wasn't related to the bugfix, and so has been
> removed.  To do this, changed i915_wait_request to be a macro to assure
> old behavior is kept.

Yuck. Using a macro and creating a new name which is nearly identical to
the old name is asking for trouble. The function signature change will
ensure that all callers are caught, and so the old callers can be
updated to pass 'false'. Given that there are only half a dozen callers,
it should be easy to just fix them.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120124/ec4f43d2/attachment.sig>

More information about the Intel-gfx mailing list